LUCENE-10008: Respect ignoreCase flag in CommonGramsFilterFactory #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mikemccand
reviewed
Oct 5, 2021
There was a problem hiding this comment.
Thank you @vigyasharma -- sorry I took so long to review -- this nearly fell past the event-horizon of my TODO list!
I left one small comment about moving the CHANGES entry to the right place, otherwise I think this is good to go for an eventual 8.11 release.
lucene/CHANGES.txt
Outdated
| @@ -648,6 +648,8 @@ Optimizations | |||
|
|
|||
| Bug Fixes | |||
| --------------------- | |||
| * LUCENE-10008: Respect ignoreCase in CommonGramsFilterFactory (Vigya Sharma) | |||
There was a problem hiding this comment.
Whoa, this is in the wrong (Lucene 8.6.0) section of CHANGES!
Since the 8.10 bits have already been set free, can you move this to the new 8.11 section?
There was a problem hiding this comment.
Oops, my bad. Thanks for checking this Mike. Moved this line to 8.11 section.
vigyasharma
force-pushed
the
lucene-10008
branch
from
3726571 to
fa43ff5
Compare
mikemccand
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting a bug fix pushed into
apache/lucene:mainas part of this PR - apache/lucene#188Description
CommonGramsFilterFactoryshould respect the ignoreCase flag passed in args even when the default stop word set is used. It currently ignores the flag ifcommonWordFilesare not specified.Solution
Ensure the flag is respected in even when default stop word set is used.
Tests
Added test to ensure that bigrams get constructed with common words that are not in lower case, when
ignoreCaseis passed astrueto theCommonGramsFilterFactory.