-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MINVOKER-306] - Fixed bug if only exclude-patterns specified #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We change some of logic - please create new issue with description, examples and justifications
src/it/invocation-cmdline-exclude/src/it/minvoker-140-executable/pom.xml
Outdated
Show resolved
Hide resolved
This PR is only bugfix, it contains nothing new. Logic is the same - "all except testX", but syntax |
You are right it is a bug. We need issues for tracking - what next release will contains. You also remove default PR template, which contains some of formal information about contributing license - please restore at lest such information. |
Done. Jira ticket created - MINVOKER-306 and pull request description modified to standard view |
25a2fc2
to
4a9771a
Compare
In addition to MINVOKER-140: exclude patterns works only if one or more include pattern(s) exists. This is a feature of plexus-utils Component DirectoryScanner.
So, in our case command line parameter
-Dinvoker.test=!testX
(and configuration parameter invokerTest ) works absolutely different way: all projects (not only testX) will be skipped. We must use-Dinvoker.test=*,!testX
or-Dinvoker.test=!testX,*
as workarround.In this commit I add forced additional include pattern "*" as default include pattern for cases, when invoker.test contains only exclude-patterns. User still use
-Dinvoker.test=!testX
and all will work correctly for him. The change is full back-compatibile with current plugin settings.Integration test invocation-cmdline-exclude is actualized, JIRA Ticket created: MINVOKER-306.
Following this checklist to help us incorporate your contribution quickly and easily:
Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like
[MINVOKER-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MINVOKER-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
You have run the integration tests successfully (
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.