-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop banner name #180
Drop banner name #180
Conversation
@@ -23,7 +23,6 @@ under the License. | |||
xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.1 https://maven.apache.org/xsd/decoration-1.8.1.xsd"> | |||
|
|||
<bannerLeft> | |||
<name>${project.name}</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that can be also done for old version of m-site-p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried, does work.
And should we also change in: maven-parent/docs/src/site/site.xml Lines 26 to 30 in c6750df
|
Good catch! |
We don't need a banner name since we use an image as a banner. Both we be displayed side-by-side with Maven Fluido Skin 2.0.0. If the banner image needs an alternative text, the new Site Model does provide such an attribute.
@michael-o is it ready? |
Let me finish Surefire and Maven Dependency Plugin then I will get back to this and refresh my memory. |
Will target before 43 release. |
Superseded by #191. |
We don't need a banner name since we use an image as a banner. Both we be displayed side-by-side with Maven Fluido Skin 2.0.0. If the banner image needs an alternative text, the new Site Model does provide such an attribute.
Addresses one of the issues from https://the-asf.slack.com/archives/C7Q9JB404/p1715479275966359