Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop banner name #180

Closed
wants to merge 1 commit into from
Closed

Drop banner name #180

wants to merge 1 commit into from

Conversation

michael-o
Copy link
Member

We don't need a banner name since we use an image as a banner. Both we be displayed side-by-side with Maven Fluido Skin 2.0.0. If the banner image needs an alternative text, the new Site Model does provide such an attribute.

Addresses one of the issues from https://the-asf.slack.com/archives/C7Q9JB404/p1715479275966359

@@ -23,7 +23,6 @@ under the License.
xsi:schemaLocation="http://maven.apache.org/DECORATION/1.8.1 https://maven.apache.org/xsd/decoration-1.8.1.xsd">

<bannerLeft>
<name>${project.name}</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope that can be also done for old version of m-site-p

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried, does work.

@slawekjaranowski
Copy link
Member

slawekjaranowski commented May 12, 2024

And should we also change in:

<bannerLeft>
<name>${project.name}</name>
<src>https://maven.apache.org/images/apache-maven-project.png</src>
<href>https://www.apache.org/</href>
</bannerLeft>

@michael-o
Copy link
Member Author

And should we also change in:

<bannerLeft>
<name>${project.name}</name>
<src>https://maven.apache.org/images/apache-maven-project.png</src>
<href>https://www.apache.org/</href>
</bannerLeft>

Good catch!

We don't need a banner name since we use an image as a banner. Both we be
displayed side-by-side with Maven Fluido Skin 2.0.0. If the banner image
needs an alternative text, the new Site Model does provide such an attribute.
@asfgit asfgit force-pushed the drop-banner-name branch from 90d1afd to 79bfaa5 Compare May 12, 2024 10:23
@slawekjaranowski slawekjaranowski added this to the MAVEN-43 milestone Jun 8, 2024
@slawekjaranowski
Copy link
Member

@michael-o is it ready?

@michael-o
Copy link
Member Author

@michael-o is it ready?

Let me finish Surefire and Maven Dependency Plugin then I will get back to this and refresh my memory.

@slawekjaranowski slawekjaranowski modified the milestone: MAVEN-43 Jun 9, 2024
@michael-o
Copy link
Member Author

@michael-o is it ready?

Let me finish Surefire and Maven Dependency Plugin then I will get back to this and refresh my memory.

Will target before 43 release.

@michael-o
Copy link
Member Author

Superseded by #191.

@michael-o michael-o closed this Jul 3, 2024
@michael-o michael-o deleted the drop-banner-name branch July 3, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants