-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a copyright messaging to the BpackingAvx512.hh #1691
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making a PR, @guangzegu .
Actually, here is the ASF legal policy.
Do not add the standard Apache License header to the top of third-party source files.
If this file falls into third-party source file, we need to remove ASF License.
cc @wpleonardo as the author of this PR.
cc @wgtmac , @williamhyun , @stiga-huang , @coderex2522 from #1375 reviewers.
@@ -16,6 +16,46 @@ | |||
* limitations under the License. | |||
*/ | |||
|
|||
/******************************************************************************* | |||
* Copyright (C) 2022 Intel Corporation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give us the original source link?
If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that |
It would be even better if you could provide the original source of the code. |
The source code link: https://github.com/intel/qpl/blob/c2ced94c53c1ee22191201a59878e9280bc9b9b8/sources/core-sw/src/filtering/opt/qplc_unpack_be_8u_k0.h#L158 |
@wpleonardo Sorry to hear that |
What changes were proposed in this pull request?
Add copyright messaging to BpackingAvx512.hh
Why are the changes needed?
The vector unpacking functions in this PR https://github.com/apache/orc/pull/1375 is derived from Intel's QPL library, hence, Maybe copyright messaging should be added.
QPL Link: https://github.com/intel/qpl
How was this patch tested?
N/A