[WIP] Add support for geometry type #2032
Conversation
java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
Outdated
Show resolved
Hide resolved
java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java
Outdated
Show resolved
Hide resolved
|
Thanks for implementing this! I will hold my review until the spec has been finalized. |
| @@ -76,7 +76,7 @@ | |||
| <maven.version>3.9.6</maven.version> | |||
|
|
|||
| <mockito.version>5.10.0</mockito.version> | |||
| <orc-format.version>1.0.0</orc-format.version> | |||
| <orc-format.version>1.0.0-SNAPSHOT</orc-format.version> | |||
There was a problem hiding this comment.
? AFAIK, we didn't change anything relevant until now, do we need -SNAPSHOT?
There was a problem hiding this comment.
Thank you for the review. The spec of geometry type haven't been merged into orc format yet, so I created a private package for developing here. Maybe it's a little bit early for code reviewing, let's waiting for the spec finished first.
| @@ -85,6 +85,7 @@ | |||
| <surefire.version>3.0.0-M5</surefire.version> | |||
| <test.tmp.dir>${project.build.directory}/testing-tmp</test.tmp.dir> | |||
| <zstd-jni.version>1.5.6-4</zstd-jni.version> | |||
| <jts.version>1.19.0</jts.version> | |||
There was a problem hiding this comment.
This seems to be too old because it's released on Jun 21, 2022.
Why don't we use the latest one? Is there any incompatibility issue with something?
|
apache/parquet-format#240 is still under review and subject to change. I think we can wait until it has been finalized. @dongjoon-hyun |
|
Ya, I want to check ETA for this work. Do you think we can have this for Apache ORC 2.1? |
|
If 2.1.0 will be released around January 17, 2025, then I think yes. |
What changes were proposed in this pull request?
POC of geometry type supporting
Why are the changes needed?
Add support for geometry type
How was this patch tested?
UT passed
Was this patch authored or co-authored using generative AI tooling?
NO