-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Broker] Avoid call sync method in async rest API for reset cursor #13841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
force-pushed
the
fix_reset_cursor
branch
from
January 19, 2022 15:57
5765d68
to
1eb49ba
Compare
26 tasks
23 tasks
nodece
force-pushed
the
fix_reset_cursor
branch
from
January 24, 2022 14:49
1eb49ba
to
e1fe107
Compare
nodece
changed the title
Avoid call sync method in async rest API for reset cursor
[Broker] Avoid call sync method in async rest API for reset cursor
Jan 24, 2022
/pulsarbot rerun-failure-checks |
nodece
force-pushed
the
fix_reset_cursor
branch
3 times, most recently
from
January 25, 2022 17:16
202e023
to
5747a19
Compare
codelipenghui
requested review from
codelipenghui,
315157973,
BewareMyPower,
hangc0276 and
zymap
January 26, 2022 02:28
nodece
force-pushed
the
fix_reset_cursor
branch
from
January 26, 2022 04:23
5747a19
to
9356e51
Compare
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Outdated
Show resolved
Hide resolved
nodece
force-pushed
the
fix_reset_cursor
branch
2 times, most recently
from
January 26, 2022 08:19
e477a17
to
73a7edf
Compare
Signed-off-by: Zixuan Liu <[email protected]>
nodece
force-pushed
the
fix_reset_cursor
branch
from
January 27, 2022 08:21
ff3ac65
to
78c9644
Compare
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
/pulsarbot rerun-failure-checks |
Technoboy-
reviewed
Jan 28, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
Show resolved
Hide resolved
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zixuan Liu [email protected]
Motivation
Avoid zk callback thread blocked, same with #13666
Modifications
Documentation
Need to update docs?
no-need-doc