Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Broker] Avoid call sync method in async rest API for reset cursor #13841

Closed
wants to merge 3 commits into from

Conversation

nodece
Copy link
Member

@nodece nodece commented Jan 19, 2022

Signed-off-by: Zixuan Liu [email protected]

Motivation

Avoid zk callback thread blocked, same with #13666

Modifications

  • Change sync method to async

Documentation

Need to update docs?

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 19, 2022
@nodece nodece marked this pull request as draft January 20, 2022 02:36
@nodece nodece marked this pull request as ready for review January 24, 2022 14:49
@nodece nodece changed the title Avoid call sync method in async rest API for reset cursor [Broker] Avoid call sync method in async rest API for reset cursor Jan 24, 2022
@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 24, 2022
@nodece
Copy link
Member Author

nodece commented Jan 25, 2022

/pulsarbot rerun-failure-checks

@nodece nodece force-pushed the fix_reset_cursor branch 3 times, most recently from 202e023 to 5747a19 Compare January 25, 2022 17:16
@nodece nodece force-pushed the fix_reset_cursor branch 2 times, most recently from e477a17 to 73a7edf Compare January 26, 2022 08:19
Signed-off-by: Zixuan Liu <[email protected]>
Signed-off-by: Zixuan Liu <[email protected]>
@nodece
Copy link
Member Author

nodece commented Jan 28, 2022

/pulsarbot rerun-failure-checks

@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs lifecycle/stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants