[fix][doc] remove This example uses Pulsar x.x.x
#17533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
approved these changes
Sep 8, 2022
Anonymitaet
approved these changes
Sep 8, 2022
github-actions
bot
added
the
doc
momo-jun
reviewed
Sep 8, 2022
momo-jun
reviewed
Sep 8, 2022
momo-jun
reviewed
Sep 8, 2022
momo-jun
reviewed
Sep 8, 2022
momo-jun
reviewed
Sep 8, 2022
RobertIndie
approved these changes
Sep 8, 2022
Co-authored-by: momo-jun <[email protected]>
Co-authored-by: momo-jun <[email protected]>
Co-authored-by: momo-jun <[email protected]>
Co-authored-by: momo-jun <[email protected]>
Co-authored-by: momo-jun <[email protected]>
momo-jun
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
LGTM.
@labuladong can you pls also add [fix][doc] in the PR title to align with the naming conventions?
labuladong
changed the title
This example uses Pulsar x.x.xThis example uses Pulsar x.x.x
Done. |
|
All tests passed. Could you help to merge this pr? @Anonymitaet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes comment in #17499
Modifications
Remove redundant
This example uses Pulsar x.x.xDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
cc @Anonymitaet @tisonkun @momo-jun