-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Reduce runners load for pulls that affect only doc or cpp changes #17541
Conversation
That solution is possible only when the check produced by the skipped build job isn't required That's why the skipping solution is needed at the build step level. It shouldn't be done at such a fine grain level. A workflow where the last step is the required check would be a way to solve this so that the builds wouldn't have to be scheduled at all. This would also simplify the workflows since we could remove the step level skipping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify the workflows in a way so that you add a new fan-in build job called "{workflow name} - Checks completed" from all build jobs that previously used to be listed in .asf.yaml in the required checks. When we re-add required checks to .asf.yaml, we would only add the "{workflow name} - Checks completed" check as required. This way we can do the nice optimization that you have performed in this PR.
97225d9
to
f2afaae
Compare
with: | ||
action: wait | ||
|
||
flaky-system-tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the exact reason for adding this? I would assume that it's possible to add matrix variables to cover this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes but then the new step pulsar-ci-checks-completed
needs these tests passing. Currently in the .asf.yaml
they are not listed. So now it depends only on system-tests
job and the result of this one doesn't impact the mergeablity of the pull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes you are right.
Motivation
Modifications
if
returns false, no new runners will be spawneddoc-not-needed