Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][tests] Make language function integration test classes abstract #17544

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Sep 8, 2022

Motivation

The tests from these classes are only executed from their subclasses.
In IntelliJ IDEA, if the class is not abstract, when you launch the test with the ▶️ button, it fails saying that there are no tests to execute.
If the class is abstract, when you launch the test with the ▶️ button, it asks for which subclass you want to run the test : all, ThreadRunTime, ProcessRuntime.

Modifications

trivial

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

no

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    tests

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

The tests from these classes are only executed from there subclasses
@cbornet cbornet changed the title Make language function integration test classes abstract [improve][tests] Make language function integration test classes abstract Sep 8, 2022
@nicoloboschi nicoloboschi merged commit 56fb164 into apache:master Sep 9, 2022
@cbornet cbornet deleted the abstract-function-tests branch September 9, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants