[improve][test] remove WhiteBox on MockZooKeeper #17579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
tisonkun
commented
Sep 10, 2022
| MockZooKeeper zk = createMockZooKeeperInstance(executor, readOpDelayMs); | ||
| ObjectInstantiator<ClientCnxn> clientCnxnObjectInstantiator = objenesis.getInstantiatorOf(ClientCnxn.class); | ||
| Whitebox.setInternalState(zk, "cnxn", clientCnxnObjectInstantiator.newInstance()); | ||
| return zk; | ||
| return createMockZooKeeperInstance(executor, readOpDelayMs); |
There was a problem hiding this comment.
@eolivelli this change was added by you in #8590. I don't know why we need this WhiteBox based mock and after removing it and running several tests, it seems all green.
Could you share some background here?
There was a problem hiding this comment.
Maybe the older versions of Mockito or other mock frameworks needed it
|
/pulsarbot run-failure-checks |
tisonkun
changed the title
tisonkun
changed the title
|
It's interesting that no test failed after remove the lines: ObjectInstantiator<ClientCnxn> clientCnxnObjectInstantiator = objenesis.getInstantiatorOf(ClientCnxn.class);
Whitebox.setInternalState(zk, "cnxn", clientCnxnObjectInstantiator.newInstance());I suppose that since the |
shoothzj
approved these changes
Sep 11, 2022
eolivelli
approved these changes
Sep 11, 2022
| MockZooKeeper zk = createMockZooKeeperInstance(executor, readOpDelayMs); | ||
| ObjectInstantiator<ClientCnxn> clientCnxnObjectInstantiator = objenesis.getInstantiatorOf(ClientCnxn.class); | ||
| Whitebox.setInternalState(zk, "cnxn", clientCnxnObjectInstantiator.newInstance()); | ||
| return zk; | ||
| return createMockZooKeeperInstance(executor, readOpDelayMs); |
There was a problem hiding this comment.
Maybe the older versions of Mockito or other mock frameworks needed it
tisonkun
added a commit
to tisonkun/pulsar
that referenced
this pull request
Sep 14, 2022
liangyepianzhou
pushed a commit
that referenced
this pull request
Dec 13, 2022
(cherry picked from commit c1434fd)
liangyepianzhou
added a commit
that referenced
this pull request
Dec 13, 2022
…itebox on MockZooKeeper (#17579)
liangyepianzhou
added a commit
that referenced
this pull request
Dec 13, 2022
…n MockZooKeeper (#17579)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…itebox on MockZooKeeper (apache#17579) (cherry picked from commit 0cc5dce)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
…n MockZooKeeper (apache#17579) (cherry picked from commit 8236311)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…itebox on MockZooKeeper (apache#17579) (cherry picked from commit 0cc5dce)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
…n MockZooKeeper (apache#17579) (cherry picked from commit 8236311)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master issue #16912
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)