Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve issue templates wordings #17793

Merged
merged 2 commits into from
Oct 4, 2022
Merged

improve issue templates wordings #17793

merged 2 commits into from
Oct 4, 2022

Conversation

tisonkun
Copy link
Member

This is a follow-up to #16902. See #16902 (comment).

Documentation

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

Matching PR in forked repository

N/A

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Sep 22, 2022
@tisonkun
Copy link
Member Author

ping @lhotari @nicoloboschi @dave2wave

@lhotari
Copy link
Member

lhotari commented Oct 4, 2022

@tisonkun
Please add these 2 lines in .github/changes-filter.yaml under docs:

  - '.github/changes-filter.yaml'
  - '.github/ISSUE_TEMPLATE/**'

that would allow skipping the tests when issue templates or changes-filter.yaml are edited.

@tisonkun
Copy link
Member Author

tisonkun commented Oct 4, 2022

@lhotari Yes. I'm thinking of it. Adding them now.

@lhotari
Copy link
Member

lhotari commented Oct 4, 2022

@lhotari Yes. I'm thinking of it. Adding them now.

@tisonkun oh sorry, I pushed already since I wanted to merge this now. :)

@lhotari lhotari merged commit 8b5acd6 into apache:master Oct 4, 2022
@tisonkun
Copy link
Member Author

tisonkun commented Oct 4, 2022

@lhotari never mind. It does no harm :)

@tisonkun tisonkun deleted the template branch October 4, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants