Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] reference to C++ and Python client #17919

Merged
merged 3 commits into from
Oct 5, 2022

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Oct 4, 2022

This closes #17916.

Documentation

  • doc-required
  • doc-not-needed
  • doc
  • doc-complete

Matching PR in forked repository

PR in forked repository: tisonkun#4

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Oct 4, 2022
@tisonkun
Copy link
Member Author

tisonkun commented Oct 4, 2022

@tisonkun
Copy link
Member Author

tisonkun commented Oct 4, 2022

/pulsarbot run-failure-checks

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@tisonkun
Copy link
Member Author

tisonkun commented Oct 4, 2022

@merlimat thank you! Comments addressed.

@tisonkun tisonkun requested review from merlimat and removed request for nicoloboschi October 4, 2022 23:31
@tisonkun
Copy link
Member Author

tisonkun commented Oct 5, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Oct 5, 2022

@merlimat @BewareMyPower CI failed on #17921

I don't know whether it's related to this patch: I can pass the test locally, and it seems logically unrelated. But also I don't ever see it before. Perhaps rerun once more to see.

@tisonkun
Copy link
Member Author

tisonkun commented Oct 5, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Oct 5, 2022

It seems rerun does not work.

ping @merlimat @lhotari @BewareMyPower

@BewareMyPower
Copy link
Contributor

BewareMyPower commented Oct 5, 2022

@tisonkun The tests (of 4742b6f) passed in my local env, I'll rerun again.

@merlimat merlimat merged commit 1234698 into apache:master Oct 5, 2022
@tisonkun tisonkun deleted the cleanup-reference-to-client-cpp branch October 9, 2022 07:37
@Anonymitaet
Copy link
Member

@tisonkun thank you! I've updated other related occurrences apache/pulsar-site#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup or migrate all reference to pulsar-client-cpp and the python client
5 participants