Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Fix String wrong format #21829

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Jan 1, 2024

Motivation

Fix the String wrong format introduced by this PR #21169

Modifications

String.format("xxx {} xxxx", "xxx") -> String.format("xxx %s xxxx", "xxx")

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@AnonHxy AnonHxy self-assigned this Jan 1, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 1, 2024
@AnonHxy AnonHxy added type/bug The PR fixed a bug or issue reported a bug release/3.1.3 ready-to-test labels Jan 1, 2024
@AnonHxy AnonHxy changed the title [broker][fix] Fix String wrong format [fix][broker] Fix String wrong format Jan 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (200c925) 73.59% compared to head (318edbd) 73.59%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21829      +/-   ##
============================================
- Coverage     73.59%   73.59%   -0.01%     
  Complexity    32294    32294              
============================================
  Files          1858     1858              
  Lines        138144   138144              
  Branches      15141    15141              
============================================
- Hits         101670   101662       -8     
- Misses        28607    28616       +9     
+ Partials       7867     7866       -1     
Flag Coverage Δ
inttests 24.15% <0.00%> (-0.13%) ⬇️
systests 23.73% <0.00%> (-0.31%) ⬇️
unittests 72.87% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedLedgerImpl.java 80.61% <0.00%> (-0.13%) ⬇️
...va/org/apache/pulsar/broker/service/ServerCnx.java 72.14% <0.00%> (+0.05%) ⬆️
...roker/service/persistent/PersistentReplicator.java 68.54% <0.00%> (+0.99%) ⬆️
...ker/service/persistent/PersistentSubscription.java 76.91% <0.00%> (+0.44%) ⬆️
...r/impl/SnapshotSegmentAbortedTxnProcessorImpl.java 78.51% <0.00%> (ø)
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 79.25% <0.00%> (ø)
...pulsar/broker/admin/impl/PersistentTopicsBase.java 64.89% <0.00%> (+0.15%) ⬆️

... and 60 files with indirect coverage changes

@Technoboy- Technoboy- merged commit 529e1ab into apache:master Jan 2, 2024
59 of 62 checks passed
Technoboy- added a commit that referenced this pull request Jan 22, 2024
Technoboy- added a commit to Technoboy-/pulsar that referenced this pull request Feb 5, 2024
nodece pushed a commit to nodece/pulsar that referenced this pull request Feb 23, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 15, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 17, 2024
mukesh-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 19, 2024
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants