-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [broker] Subscription stuck due to called Admin API analyzeSubscriptionBacklog #22019
Merged
dao-jun
merged 12 commits into
apache:master
from
poorbarcode:fix/stuck_by_analyzeSubscriptionBacklog
Feb 18, 2024
Merged
[fix] [broker] Subscription stuck due to called Admin API analyzeSubscriptionBacklog #22019
dao-jun
merged 12 commits into
apache:master
from
poorbarcode:fix/stuck_by_analyzeSubscriptionBacklog
Feb 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poorbarcode
added
release/3.0.3
release/2.11.4
release/3.1.3
release/3.2.1
type/bug
The PR fixed a bug or issue reported a bug
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
labels
Feb 4, 2024
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpScan.java
Outdated
Show resolved
Hide resolved
gaoran10
reviewed
Feb 4, 2024
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Outdated
Show resolved
Hide resolved
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Show resolved
Hide resolved
Technoboy-
reviewed
Feb 4, 2024
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedger.java
Outdated
Show resolved
Hide resolved
A new update: The new Non-Durable cursor has not copied the ack state when creating, I will fix it tomorrow. New update(2024-02-05): fixed |
poorbarcode
requested review from
Technoboy- and
codelipenghui
and removed request for
codelipenghui
February 5, 2024 02:13
gaoran10
reviewed
Feb 5, 2024
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java
Outdated
Show resolved
Hide resolved
gaoran10
approved these changes
Feb 5, 2024
Technoboy-
approved these changes
Feb 18, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #22019 +/- ##
============================================
+ Coverage 72.90% 73.56% +0.66%
- Complexity 32464 32559 +95
============================================
Files 1850 1874 +24
Lines 138611 139253 +642
Branches 15201 15263 +62
============================================
+ Hits 101052 102444 +1392
+ Misses 29711 28888 -823
- Partials 7848 7921 +73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dao-jun
approved these changes
Feb 18, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 1, 2024
…criptionBacklog (apache#22019) (cherry picked from commit 2045c5f)
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…criptionBacklog (apache#22019) (cherry picked from commit 2045c5f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category/reliability
The function does not work properly in certain specific environments or failures. e.g. data lost
cherry-picked/branch-3.0
cherry-picked/branch-3.1
cherry-picked/branch-3.2
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.11.5
release/3.0.3
release/3.1.3
release/3.2.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Admin API
analyzeSubscriptionBacklog
will create anOpReadEntry
and trigger a read, which leadsManagecursor.readPosition
to move forward. It makes the subscription stuck(just like the consumer receives messages but does not acknowledge them).Modifications
subscription.cursor
startCursorPosition
ofnew NonDurableCursor
tomdPosition
, make the code more clearerDocumentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x