[fix][broker] Fix broker not starting when both transactions and the Extensible Load Manager are enabled #22139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested changes
Feb 28, 2024
...broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
Show resolved
Hide resolved
lhotari
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Approved. The discussion was summarized in the comment #22139 (comment)
heesung-sn
approved these changes
Feb 28, 2024
heesung-sn
changed the title
|
@dragosvictor We have a conflict in branch-3.0. Can you help to raise cherry-pick PRs for 3.0/3.1/3.2 branches? |
dragosvictor
added a commit
to dragosvictor/pulsar
that referenced
this pull request
Mar 1, 2024
…Extensible Load Manager are enabled (apache#22139)
15 tasks
dragosvictor
added a commit
to dragosvictor/pulsar
that referenced
this pull request
Mar 4, 2024
…Extensible Load Manager are enabled (apache#22139)
15 tasks
dragosvictor
added a commit
to dragosvictor/pulsar
that referenced
this pull request
Mar 4, 2024
…Extensible Load Manager are enabled (apache#22139)
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Attempting to enable both the transaction coordinator (TC) and the Extensible Load Manager (ELM) leads brokers to fail on startup. The ELM is initialized before the TC, which causes a null pointer exception to be thrown when creating (here) or subscribing (here) to service unit state topic
persistent://pulsar/system/loadbalancer-service-unit-state.Modifications
Disable transactions for the respective topic, as it is an internal topic not meant to be part of any transaction.
Verifying this change
This change added tests and can be verified as follows:
org.apache.pulsar.tests.integration.messaging.MessagingSmokeTestvalidating messaging functionality still works when the ELM only is enabled, and when both the ELM and TC are enabled. The test can be easily extended to add more broker configuration combinations. Note that it takes around 9 minutes to run one combination. This test could be a candidate for a lower-frequency test job. Suggestions welcome.ExtensibleLoadManagerImplWithTransactionCoordinatorTest#testUnloadAdminAPIto quickly validate that the broker can start with both features enabled and perform a basic API call into the ELM.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/dragosvictor/pulsar/pull/14/files