-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][client] Initializing client-authentication using configured auth params #23610
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23610 +/- ##
============================================
+ Coverage 73.57% 74.33% +0.75%
- Complexity 32624 34961 +2337
============================================
Files 1877 1944 +67
Lines 139502 147129 +7627
Branches 15299 16226 +927
============================================
+ Hits 102638 109362 +6724
- Misses 28908 29316 +408
- Partials 7956 8451 +495
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
…h params (apache#23610) (cherry picked from commit 13f77aa) (cherry picked from commit 9df41fc)
…h params (apache#23610) (cherry picked from commit 13f77aa) (cherry picked from commit 9df41fc)
Motivation
Currently, there are user applications that want to load client configurations dynamically from a config file and create PulsarClient by passing that dynamically created ClientConfigurationData. In that case, the Pulsar client doesn't initialize authentication with provided auth parameters and authPluginClass into ClientConfigurationData, so user applications are not able to configure authentication correctly.
Therefore, PulsarClient should initialize authentication based on provided auth configuration (param and auth-class) and use it for server connection.
Modifications
Pulsar client lib can initialize authentication using configured auth-param and class into client-configuration.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: