Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup][build] skip generating pom.xml.versionsBackup #23639

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Nov 26, 2024

Fixes spurious backup files found in source distribution tarballs -source-release.zip like https://repo.maven.apache.org/maven2/org/apache/pulsar/pulsar/4.0.0/pulsar-4.0.0-source-release.zip

Main Issue: #xyz

PIP: #xyz

Motivation

Avoid unwanted files in official source distribution files

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

Copy link

@hboutemy Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 26, 2024
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @hboutemy

@lhotari lhotari added this to the 4.1.0 milestone Nov 26, 2024
@lhotari lhotari merged commit dbfde02 into apache:master Nov 27, 2024
62 of 63 checks passed
lhotari pushed a commit that referenced this pull request Nov 27, 2024
lhotari pushed a commit that referenced this pull request Nov 27, 2024
lhotari pushed a commit that referenced this pull request Nov 27, 2024
nikhil-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 28, 2024
(cherry picked from commit dbfde02)
(cherry picked from commit 165ddb4)
srinath-ctds pushed a commit to datastax/pulsar that referenced this pull request Nov 28, 2024
(cherry picked from commit dbfde02)
(cherry picked from commit 165ddb4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants