-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker] Reduce memory occupation of InMemoryRedeliveryTracker. #23640
[improve][broker] Reduce memory occupation of InMemoryRedeliveryTracker. #23640
Conversation
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/InMemoryRedeliveryTracker.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/InMemoryRedeliveryTracker.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/InMemoryRedeliveryTracker.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work @thetumbled
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23640 +/- ##
============================================
+ Coverage 73.57% 74.34% +0.76%
- Complexity 32624 34997 +2373
============================================
Files 1877 1944 +67
Lines 139502 147224 +7722
Branches 15299 16246 +947
============================================
+ Hits 102638 109453 +6815
- Misses 28908 29322 +414
- Partials 7956 8449 +493
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Motivation
Reduce memory occupation of the
InMemoryRedeliveryTracker
.Modifications
Use
Long2ObjectMap<Long2IntMap>
to replaceConcurrentLongLongPairHashMap
.Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: thetumbled#66