Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-3714 Deprecate and repackage common APIs part 1 #1079

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Oct 17, 2024

WW-3714

This PR deprecates and provides repackaged replacements for the following APIs, ahead of their permanent migration in Struts 7.0:

  • com.opensymphony.xwork2.ActionContext
  • com.opensymphony.xwork2.Action
  • com.opensymphony.xwork2.Result
  • com.opensymphony.xwork2.interceptor.Interceptor
  • com.opensymphony.xwork2.interceptor.ConditionalInterceptor

Note that these changes alone are not sufficient for defining Interceptors/Results implementing the new interfaces in XML configuration files. Factory support is also necessary which is introduced in #1087.

@kusalk kusalk force-pushed the kusal-depr-apis branch 2 times, most recently from fd3463c to 74af7e7 Compare October 17, 2024 02:35
@kusalk kusalk changed the title WW-3714 Deprecate and repackage common APIs WW-3714 Deprecate and repackage common APIs part 1 Oct 17, 2024
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@kusalk kusalk marked this pull request as ready for review October 21, 2024 10:06
@lukaszlenart
Copy link
Member

lukaszlenart commented Oct 21, 2024

Is it ready for review?

@kusalk
Copy link
Member Author

kusalk commented Oct 21, 2024

@lukaszlenart Thanks for reviewing - yep I wasn't sure whether there was a Struts 6.7 planned

@kusalk kusalk merged commit efa447a into master Oct 21, 2024
8 of 9 checks passed
@kusalk kusalk deleted the kusal-depr-apis branch October 21, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants