Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-5478 Deprecate DefaultResultFactory #1105

Merged
merged 2 commits into from
Nov 2, 2024
Merged

WW-5478 Deprecate DefaultResultFactory #1105

merged 2 commits into from
Nov 2, 2024

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Nov 1, 2024 •
edited by lukaszlenart
Loading

WW-5478

I can't see any value in maintaining this class as it does the same thing as StrutsResultFactory minus support for the marker ParamNameAwareResult.

@kusalk kusalk marked this pull request as ready for review November 1, 2024 08:56
@kusalk kusalk requested a review from lukaszlenart November 1, 2024 08:56
@kusalk kusalk force-pushed the WW-5476-defaultresultfactory branch from c73e6d1 to 1562d83 Compare November 1, 2024 08:59
@lukaszlenart lukaszlenart changed the title WW-5476 Deprecate DefaultResultFactory WW-5478 Deprecate DefaultResultFactory Nov 1, 2024
lukaszlenart
lukaszlenart approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated ticket reference, beside that looks good LGTM 👍

@kusalk
Copy link
Member Author

kusalk commented Nov 2, 2024

Oops, thank you

@kusalk kusalk force-pushed the WW-5476-defaultresultfactory branch from 1562d83 to c176390 Compare November 2, 2024 03:01
@kusalk kusalk merged commit 1908cba into master Nov 2, 2024
6 of 7 checks passed
@kusalk kusalk deleted the WW-5476-defaultresultfactory branch November 2, 2024 03:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22 Security Hotspots
42.2% Coverage on New Code (required ≥ 80%)
3.4% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@kusalk kusalk mentioned this pull request Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszlenart lukaszlenart lukaszlenart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kusalk @lukaszlenart