Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WW-3714 Move new Result class into result package #1109

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

kusalk
Copy link
Member

@kusalk kusalk commented Nov 2, 2024

WW-3714

Resolves unusual issue compiling JSPs.

Copy link

sonarcloud bot commented Nov 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@kusalk kusalk marked this pull request as ready for review November 2, 2024 12:13
@kusalk kusalk requested a review from lukaszlenart November 2, 2024 12:14
@lukaszlenart
Copy link
Member

I wouldn't do this in the master branch as this is a breaking change. Also I don't have problems with building the master branch, only with release/struts-7-x-x ;-)

Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I noticed that this is a new Result 🤦

@kusalk kusalk merged commit 2beac8e into master Nov 2, 2024
7 of 9 checks passed
@kusalk kusalk deleted the WW-3714-result-repackage branch November 2, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants