WW-3714 Ensure correct delegation of deprecated API methods #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kusalk
force-pushed
the
WW-3714-overriding-behaviour
branch
from
57e08fb to
be82a72
Compare
|
lukaszlenart
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WW-3714
Whilst working on #1116, I noticed a minor issue with how overriding of classes that implement the old/deprecated
Result/Interceptorinterfaces behave.Currently, if an application extends for example,
org.apache.struts2.result.HttpHeaderResultand overrides the new signaturevoid execute(org.apache.struts2.ActionInvocation invocation)instead of the old onevoid execute(com.opensymphony.xwork2.ActionInvocation invocation)- this override will have no effect.The changes in this PR ensure the override will function as expected irrespective of whether the old or new signature is overridden. This works because the default implementation for the new signature in the old/deprecated interfaces is to delegate to the old signature.