Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WW-5338] Removes deprecated OgnlTool #758

Merged
merged 2 commits into from
Oct 5, 2023
Merged

[WW-5338] Removes deprecated OgnlTool #758

merged 2 commits into from
Oct 5, 2023

Conversation

lukaszlenart
Copy link
Member

Closes WW-5338

kusalk
kusalk reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@kusalk kusalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also delete org.apache.struts2.views.util.ContextUtil#OGNL

@kusalk kusalk changed the title [WW-5338] Removes deprecated OgnTool [WW-5338] Removes deprecated OgnlTool Oct 4, 2023
@lukaszlenart lukaszlenart requested a review from kusalk October 4, 2023 11:23
@asfgit asfgit force-pushed the feature/WW-5338-remove-ognltool branch 2 times, most recently from 2d7bff3 to 400cb24 Compare October 4, 2023 12:04
kusalk
kusalk approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@kusalk kusalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

plugins/velocity/src/main/java/org/apache/struts2/views/velocity/VelocityManager.java Outdated Show resolved Hide resolved
@asfgit asfgit force-pushed the feature/WW-5338-remove-ognltool branch from 400cb24 to 3b41e6b Compare October 5, 2023 05:48
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@lukaszlenart lukaszlenart merged commit ff9ecbe into master Oct 5, 2023
8 checks passed
@lukaszlenart lukaszlenart deleted the feature/WW-5338-remove-ognltool branch October 5, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kusalk kusalk kusalk approved these changes

@aleksandr-m aleksandr-m Awaiting requested review from aleksandr-m

@yasserzamani yasserzamani Awaiting requested review from yasserzamani

@sdutry sdutry Awaiting requested review from sdutry

@cnenning cnenning Awaiting requested review from cnenning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukaszlenart @kusalk