diff --git a/caravel/assets/javascripts/SqlLab/components/SqlEditor.jsx b/caravel/assets/javascripts/SqlLab/components/SqlEditor.jsx index 5bab1a1a9ecf7..ef676ce3b87b6 100644 --- a/caravel/assets/javascripts/SqlLab/components/SqlEditor.jsx +++ b/caravel/assets/javascripts/SqlLab/components/SqlEditor.jsx @@ -260,7 +260,7 @@ class SqlEditor extends React.Component { mode="sql" name={this.props.queryEditor.id} theme="github" - minLines={5} + minLines={7} maxLines={30} onChange={this.textChange.bind(this)} height="200px" diff --git a/caravel/assets/javascripts/SqlLab/components/TableElement.jsx b/caravel/assets/javascripts/SqlLab/components/TableElement.jsx index d2f74bcc2495b..50a8668ccffeb 100644 --- a/caravel/assets/javascripts/SqlLab/components/TableElement.jsx +++ b/caravel/assets/javascripts/SqlLab/components/TableElement.jsx @@ -10,6 +10,7 @@ class TableElement extends React.Component { setSelectStar() { this.props.actions.queryEditorSetSql(this.props.queryEditor, this.selectStar()); } + selectStar() { let cols = ''; this.props.table.columns.forEach((col, i) => { @@ -20,6 +21,7 @@ class TableElement extends React.Component { }); return `SELECT ${cols}\nFROM ${this.props.table.name}`; } + popSelectStar() { const qe = { id: shortid.generate(), @@ -30,26 +32,40 @@ class TableElement extends React.Component { }; this.props.actions.addQueryEditor(qe); } + + collapseTable(e) { + e.preventDefault(); + this.props.actions.collapseTable.bind(this, this.props.table)(); + } + + expandTable(e) { + e.preventDefault(); + this.props.actions.expandTable.bind(this, this.props.table)(); + } + render() { let metadata = null; let buttonToggle; if (this.props.table.expanded) { buttonToggle = ( - { this.collapseTable(e); }} > - {this.props.table.name} - + {this.props.table.name} + + ); metadata = (