From a58d184711e021ad11878b42958b01fb737961cc Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Tue, 20 Oct 2015 11:52:40 -0700 Subject: [PATCH] Removing references to basestring --- panoramix/forms.py | 3 ++- panoramix/models.py | 4 +++- panoramix/viz.py | 6 ++++-- requirements.txt | 12 +++++++++--- setup.py | 2 +- 5 files changed, 19 insertions(+), 8 deletions(-) diff --git a/panoramix/forms.py b/panoramix/forms.py index 5fdeace8783ad..2f204a1a50c83 100644 --- a/panoramix/forms.py +++ b/panoramix/forms.py @@ -4,6 +4,7 @@ from wtforms import validators from copy import copy from panoramix import app +from six import string_types config = app.config @@ -240,7 +241,7 @@ class QueryForm(OmgWtForm): QueryForm, 'flt_eq_' + str(i), TextField("Super", default='')) for ff in viz.form_fields: - if isinstance(ff, basestring): + if isinstance(ff, string_types): ff = [ff] for s in ff: if s: diff --git a/panoramix/models.py b/panoramix/models.py index dfa3459140e17..8bb3bdcc982ae 100644 --- a/panoramix/models.py +++ b/panoramix/models.py @@ -22,6 +22,8 @@ import requests import textwrap +from six import string_types + from panoramix import app, db, get_session, utils from panoramix.viz import viz_types from sqlalchemy.ext.declarative import declared_attr @@ -766,7 +768,7 @@ def query( if granularity != "all": granularity = utils.parse_human_timedelta( granularity).total_seconds() * 1000 - if not isinstance(granularity, basestring): + if not isinstance(granularity, string_types): granularity = {"type": "duration", "duration": granularity} qry = dict( diff --git a/panoramix/viz.py b/panoramix/viz.py index d45a40097f325..3feb0408e08ea 100644 --- a/panoramix/viz.py +++ b/panoramix/viz.py @@ -14,6 +14,8 @@ from panoramix import app, utils from panoramix.forms import FormFactory +from six import string_types + config = app.config @@ -468,7 +470,7 @@ def to_series(self, df, classed='', title_suffix=''): if df[name].dtype.kind not in "biufc": continue df['timestamp'] = pd.to_datetime(df.index, utc=False) - if isinstance(name, basestring): + if isinstance(name, string_types): series_title = name else: name = ["{}".format(s) for s in name] @@ -622,7 +624,7 @@ def get_json_data(self): if df[name].dtype.kind not in "biufc": continue df['timestamp'] = pd.to_datetime(df.index, utc=False) - if isinstance(name, basestring): + if isinstance(name, string_types): series_title = name elif len(self.metrics) > 1: series_title = ", ".join(name) diff --git a/requirements.txt b/requirements.txt index 7af8d26e03866..de416bfefe6ce 100644 --- a/requirements.txt +++ b/requirements.txt @@ -1,5 +1,7 @@ alembic>=0.7.7, <0.8.0 -flask>=0.10.1, <1.0.0 +coverage +coveralls +flask==0.10.1 flask-appbuilder>=1.4.5, <2.0.0 flask-login==0.2.11 flask-migrate>=1.5.1, <2.0.0 @@ -7,10 +9,14 @@ flask-script>=2.0.5, <3.0.0 flask-testing>=0.4.2, <0.5.0 gunicorn>=19.3.0, <20.0.0 markdown>=2.6.2, <3.0.0 -numpy>=1.10, <2 -pandas==0.16.2, <0.17 +nose +numpy>=1.9 +pandas==0.16.2 parsedatetime>=1.5, <2.0.0 pydruid>=0.2.2, <0.3 python-dateutil>=2.4.2, <3.0.0 requests>=2.7.0, <3.0.0 sqlparse>=0.1.16, <0.2.0 +pyhive +pymysql +six diff --git a/setup.py b/setup.py index dcc5626ce3c17..85075a89dbe7f 100644 --- a/setup.py +++ b/setup.py @@ -26,7 +26,7 @@ 'flask-testing>=0.4.2, <0.5.0', 'gunicorn>=19.3.0, <20.0.0', 'markdown>=2.6.2, <3.0.0', - 'numpy>=1.10, <2', + 'numpy>=1.9, <2', 'pandas==0.16.2, <0.17', 'parsedatetime>=1.5, <2.0.0', 'pydruid>=0.2.2, <0.3',