diff --git a/superset/forms.py b/superset/forms.py index f094819ab40eb..0febecc2afb1d 100755 --- a/superset/forms.py +++ b/superset/forms.py @@ -134,7 +134,7 @@ def __init__(self, viz): default_groupby = gb_cols[0] if gb_cols else None group_by_choices = self.choicify(gb_cols) order_by_choices = [] - for s in sorted(datasource.num_cols): + for s in sorted(datasource.column_names): order_by_choices.append((json.dumps([s, True]), s + ' [asc]')) order_by_choices.append((json.dumps([s, False]), s + ' [desc]')) # Pool of all the fields that can be used in Superset diff --git a/superset/views.py b/superset/views.py index c2a832c5fff9d..1251384d93fd0 100755 --- a/superset/views.py +++ b/superset/views.py @@ -2142,7 +2142,7 @@ def fetch_datasource_metadata(self): gb_cols = [(col, col) for col in datasource.groupby_column_names] order_by_choices = [] - for s in sorted(datasource.num_cols): + for s in sorted(datasource.column_names): order_by_choices.append((json.dumps([s, True]), s + ' [asc]')) order_by_choices.append((json.dumps([s, False]), s + ' [desc]')) diff --git a/superset/viz.py b/superset/viz.py index ed1444bb85643..abdea0ff68901 100755 --- a/superset/viz.py +++ b/superset/viz.py @@ -440,7 +440,7 @@ def query_obj(self): if fd.get('all_columns'): d['columns'] = fd.get('all_columns') d['groupby'] = [] - order_by_cols = fd.get('order_by_cols', []) or [] + order_by_cols = fd.get('order_by_cols') or [] d['orderby'] = [json.loads(t) for t in order_by_cols] return d