From de444d4de6a917af8f8efe2335fb1a26ac86e6d8 Mon Sep 17 00:00:00 2001 From: Geido <60598000+geido@users.noreply.github.com> Date: Wed, 5 Oct 2022 12:38:51 +0300 Subject: [PATCH] fix: Race conditions with setupExtensions (#21647) --- superset-frontend/src/SqlLab/App.jsx | 2 ++ superset-frontend/src/preamble.ts | 3 --- superset-frontend/src/profile/App.tsx | 2 ++ superset-frontend/src/views/App.tsx | 2 ++ 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/superset-frontend/src/SqlLab/App.jsx b/superset-frontend/src/SqlLab/App.jsx index ce768fee8c3d4..812202eec20f8 100644 --- a/superset-frontend/src/SqlLab/App.jsx +++ b/superset-frontend/src/SqlLab/App.jsx @@ -29,6 +29,7 @@ import { isFeatureEnabled, FeatureFlag, } from 'src/featureFlags'; +import setupExtensions from 'src/setup/setupExtensions'; import getInitialState from './reducers/getInitialState'; import rootReducer from './reducers/index'; import { initEnhancer } from '../reduxUtils'; @@ -45,6 +46,7 @@ import '../assets/stylesheets/reactable-pagination.less'; import { theme } from '../preamble'; setupApp(); +setupExtensions(); const appContainer = document.getElementById('app'); const bootstrapData = JSON.parse(appContainer.getAttribute('data-bootstrap')); diff --git a/superset-frontend/src/preamble.ts b/superset-frontend/src/preamble.ts index f8840ed22bdf8..09ef06dafe632 100644 --- a/superset-frontend/src/preamble.ts +++ b/superset-frontend/src/preamble.ts @@ -24,7 +24,6 @@ import { configure, makeApi, supersetTheme } from '@superset-ui/core'; import { merge } from 'lodash'; import setupClient from './setup/setupClient'; import setupColors from './setup/setupColors'; -import setupExtensions from './setup/setupExtensions'; import setupFormatters from './setup/setupFormatters'; import setupDashboardComponents from './setup/setupDasboardComponents'; import { BootstrapUser, User } from './types/bootstrapTypes'; @@ -34,8 +33,6 @@ if (process.env.WEBPACK_MODE === 'development') { setHotLoaderConfig({ logLevel: 'debug', trackTailUpdates: false }); } -setupExtensions(); - // eslint-disable-next-line import/no-mutable-exports export let bootstrapData: { user?: BootstrapUser; diff --git a/superset-frontend/src/profile/App.tsx b/superset-frontend/src/profile/App.tsx index 1f2cd144afcc1..3704dcb4b5f4f 100644 --- a/superset-frontend/src/profile/App.tsx +++ b/superset-frontend/src/profile/App.tsx @@ -27,10 +27,12 @@ import App from 'src/profile/components/App'; import messageToastReducer from 'src/components/MessageToasts/reducers'; import { initEnhancer } from 'src/reduxUtils'; import setupApp from 'src/setup/setupApp'; +import setupExtensions from 'src/setup/setupExtensions'; import { theme } from 'src/preamble'; import ToastContainer from 'src/components/MessageToasts/ToastContainer'; setupApp(); +setupExtensions(); const profileViewContainer = document.getElementById('app'); const bootstrap = JSON.parse( diff --git a/superset-frontend/src/views/App.tsx b/superset-frontend/src/views/App.tsx index f13b9c55013b0..21a38684912fe 100644 --- a/superset-frontend/src/views/App.tsx +++ b/superset-frontend/src/views/App.tsx @@ -34,12 +34,14 @@ import setupApp from 'src/setup/setupApp'; import setupPlugins from 'src/setup/setupPlugins'; import { routes, isFrontendRoute } from 'src/views/routes'; import { Logger } from 'src/logger/LogUtils'; +import setupExtensions from 'src/setup/setupExtensions'; import { RootContextProviders } from './RootContextProviders'; import { ScrollToTop } from './ScrollToTop'; import QueryProvider from './QueryProvider'; setupApp(); setupPlugins(); +setupExtensions(); const user = { ...bootstrapData.user }; const menu = {