Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] Upgrade to npm 7 #13067

Closed
ktmud opened this issue Feb 11, 2021 · 1 comment · Fixed by #13100
Closed

[TODO] Upgrade to npm 7 #13067

ktmud opened this issue Feb 11, 2021 · 1 comment · Fixed by #13100
Labels

Comments

@ktmud
Copy link
Member

ktmud commented Feb 11, 2021

https://github.blog/2021-02-02-npm-7-is-now-generally-available/

npm 7 is now generally available and your local npm may have been upgraded if you have auto-update turned on.

But it has some breaking changes, most notably the new lockfile format and how it handles peerDependencies. I did some testing and it seems the behavior for npm link has also changed---previously it will run npm install in linked packages, but now it doesn't (there is an open issue for this: npm/cli#2339)

Extra care is needed to update package-lock.json and package dependencies in superset-ui may have to be updated to accommodate the new peer dependency behavior.

Every committer MUST be notified to upgrade their local npm, too, when we do upgrade to npm 7, because of these breaking changes.

cc @rusackas @villebro @kgabryje @maloun96 @amitmiran137

@ktmud
Copy link
Member Author

ktmud commented Feb 12, 2021

Looks like package-lock.json is inadvertently upgraded by #13079 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants