Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQLLab] Timestamp column type metadata shows up incorrectly in left panel #16258

Closed
3 tasks done
michellethomas opened this issue Aug 14, 2021 · 3 comments · Fixed by #16614
Closed
3 tasks done

[SQLLab] Timestamp column type metadata shows up incorrectly in left panel #16258

michellethomas opened this issue Aug 14, 2021 · 3 comments · Fixed by #16614
Assignees
Labels
#bug Bug report sqllab Namespace | Anything related to the SQL Lab

Comments

@michellethomas
Copy link
Contributor

If you look up a table in sqllab on the left hand side to see the table metadata, tables with timestamp types show up as:

<class 'superset.models.sql_types.base.literal_dttm_type_factory..TemporalWrapperType'>

Expected results

The correct type.

Actual results

<class 'superset.models.sql_types.base.literal_dttm_type_factory..TemporalWrapperType'>

How to reproduce the bug

  1. Add schema and a table to the left panel for a table with a timestamp type to see the table metadata (we noticed this in Presto)
  2. When the table metadata shows up see "<class 'superset.models.sql_types.base.literal_dttm_type_factory..TemporalWrapperType'>" for the type instead of the correct type

Left panel
image

Environment

(please complete the following information):

  • superset version: master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@michellethomas michellethomas added sqllab Namespace | Anything related to the SQL Lab #bug Bug report labels Aug 14, 2021
@etr2460
Copy link
Member

etr2460 commented Aug 27, 2021

Hi @yousoph , any updates on roadmapping this issue? Thanks!

@caoquyvu
Copy link

caoquyvu commented Sep 7, 2021

Got the same error

@villebro villebro self-assigned this Sep 7, 2021
@villebro
Copy link
Member

villebro commented Sep 7, 2021

I'll look into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants