-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python 2 support #1686
Comments
Python 2.7 is there to stay. In many environments people might now have the luxury to choose. We use it in production at Airbnb. We could run 3.4 or 3.5 if we wanted but we'll probably make the switch when our standard images use distros that ship py3 by default. So even though it reduce the surface for bugs, we're not dropping py2.7 support, I don't think there's a lot of projects that are doing that at the moment. I'm not sure what your exact issues were, but most likely something that's easy to fix across the board with some environment (or perhaps database connection) setting. |
An easy reproducer for sqllab breaking with python2.7 is something like this on a table from the examples:
Closing then. |
Another fact that should be kept in mind: python-ldap is not available for python3. |
@rumbin except you can upgrade :) https://github.com/pyldap/pyldap. |
@xrmx thanks for pointing me to pyldap, it seems to work well! |
I'm wondering if it's time to stop supporting superset on python 2. I created by mistake a virtualenv with python2 instead of python3 and sqllab does not work at all when non ascii encodable data is used. It breaks in the loggers, it breaks when poking with dataframes.
So given that airbnb is on python3 and tests does not catch any encoding issue is it time to stop supporting it?
The text was updated successfully, but these errors were encountered: