Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 2 support #1686

Closed
xrmx opened this issue Nov 24, 2016 · 5 comments · Fixed by #1696
Closed

python 2 support #1686

xrmx opened this issue Nov 24, 2016 · 5 comments · Fixed by #1696

Comments

@xrmx
Copy link
Contributor

xrmx commented Nov 24, 2016

I'm wondering if it's time to stop supporting superset on python 2. I created by mistake a virtualenv with python2 instead of python3 and sqllab does not work at all when non ascii encodable data is used. It breaks in the loggers, it breaks when poking with dataframes.
So given that airbnb is on python3 and tests does not catch any encoding issue is it time to stop supporting it?

@xrmx xrmx added the question label Nov 24, 2016
@mistercrunch
Copy link
Member

Python 2.7 is there to stay. In many environments people might now have the luxury to choose.

We use it in production at Airbnb. We could run 3.4 or 3.5 if we wanted but we'll probably make the switch when our standard images use distros that ship py3 by default.

So even though it reduce the surface for bugs, we're not dropping py2.7 support, I don't think there's a lot of projects that are doing that at the moment.

I'm not sure what your exact issues were, but most likely something that's easy to fix across the board with some environment (or perhaps database connection) setting.

@xrmx
Copy link
Contributor Author

xrmx commented Nov 28, 2016

An easy reproducer for sqllab breaking with python2.7 is something like this on a table from the examples:

select 'ኴ' from anexampletable;

Closing then.

@rumbin
Copy link
Contributor

rumbin commented Jan 31, 2017

Another fact that should be kept in mind:

python-ldap is not available for python3.
LDAP-auth is the sole reason why we run superset in a python2.7 venv.

@xrmx
Copy link
Contributor Author

xrmx commented Jan 31, 2017

@rumbin except you can upgrade :) https://github.com/pyldap/pyldap.

@rumbin
Copy link
Contributor

rumbin commented Jan 31, 2017

@xrmx thanks for pointing me to pyldap, it seems to work well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants