Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superset Table UI unusable with infinite scrollbar flashing #22393

Closed
3 tasks done
opqpop opened this issue Dec 12, 2022 · 10 comments
Closed
3 tasks done

Superset Table UI unusable with infinite scrollbar flashing #22393

opqpop opened this issue Dec 12, 2022 · 10 comments
Assignees
Labels
#bug Bug report preset:cares Preset cares about this issue validation:required A committer should validate the issue

Comments

@opqpop
Copy link

opqpop commented Dec 12, 2022

superset_hmm.mov

See video where both vertical and horizontal scroll for the table is flashing initially, but is sometimes fixed when we click "Aggregate" and then switch back to "Raw Records". Doesn't always fix it however

How to reproduce the bug

Go to any Superset Table UI and select a column, then scrollbar starts flashing

Expected results

No flashing

Actual results

See video

Environment

(please complete the following information):

  • browser type and version: Chrome Version 107.0.5304.110 (Official Build) (arm64)
  • python version: python --version: Python 3.10.8
  • any feature flags active: none

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@opqpop opqpop added the #bug Bug report label Dec 12, 2022
@rusackas rusackas added the validation:required A committer should validate the issue label Dec 12, 2022
@rusackas
Copy link
Member

Pinging @lauderbaugh and @kgabryje for a little triage/repro/troubleshooting on this one.

@rusackas
Copy link
Member

@opqpop are you seeing this issue in Explore only, or in the Dashboard view too?

And is it happening with any other chart types, or just the Table?

@sfirke
Copy link
Member

sfirke commented Dec 15, 2022

Thanks for reporting this, I had meant to. 2.0.0. A teammate and I can both reproduce it on some of our charts. We opened the developer tools in the browser (Chrome and Firefox) and could see the page code changing as the chart flickered.

@rusackas rusackas added the preset:cares Preset cares about this issue label Dec 15, 2022
@opqpop
Copy link
Author

opqpop commented Dec 16, 2022

@opqpop are you seeing this issue in Explore only, or in the Dashboard view too?

And is it happening with any other chart types, or just the Table?

ah sorry for the delayed reponse, I see it in Explore only

Only seeing the issue for Tables

@rusackas
Copy link
Member

Out of curiosity, are you using a PC with Chrome? And did your table chart have the "Show Totals" checkbox enabled? If so, I just merged a PR that might fix this. Please check the latest master and see if this resolves your issue.

@sfirke
Copy link
Member

sfirke commented Dec 20, 2022

is sometimes fixed when we click "Aggregate" and then switch back to "Raw Records". Doesn't always fix it however

This sounds sketchy but I can 100% replicate this. I am sitting here with my table chart in 2.0.1rc6 and clicking back and forth between Aggregate and Raw Records. Sometimes it flashes after changing that, sometimes it doesn't.

@opqpop
Copy link
Author

opqpop commented Dec 20, 2022

Out of curiosity, are you using a PC with Chrome? And did your table chart have the "Show Totals" checkbox enabled? If so, I just merged a PR that might fix this. Please check the latest master and see if this resolves your issue.

I'm using a mac to access our superset instance that's hosted on

I'm having trouble finding the "Show Totals" checkbox, where can I find it?

image

@frabenetti
Copy link

frabenetti commented Jan 20, 2023

Hi all, I have the same issue in version 2.0.1.
Windows 11, Chrome Version 109.0.5414.75 (Official Build) (64 bit) and of course MS Edge. It does not happen with Firefox Version 109 (64-bit).

@frabenetti
Copy link

hi all, just testing around this issue. It seems related to the vertical scroll bar, if you enlarge the the window till the bottom, it stops flashing. Hope this helps.

@rusackas
Copy link
Member

rusackas commented Feb 9, 2023

Closing in favor of #22784 which includes a link to the fix PR, #20833.

Thanks @sfirke for the duplication alert, and thanks @Antonio-RiveroMartnez for the fix!

@rusackas rusackas closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report preset:cares Preset cares about this issue validation:required A committer should validate the issue
Projects
None yet
Development

No branches or pull requests

5 participants