Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Pivot Sort order - 1M is considered less than 100K #4132

Closed
2 tasks
manoc opened this issue Dec 28, 2017 · 7 comments
Closed
2 tasks

In Pivot Sort order - 1M is considered less than 100K #4132

manoc opened this issue Dec 28, 2017 · 7 comments
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days

Comments

@manoc
Copy link

manoc commented Dec 28, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • [Y] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.22.1

Expected results

In Pivot when we sort ascending by any measure, it supposed to show 100K above and 1M below.

Actual results

It considered 1.07M is less than 100K
image

Steps to reproduce

Open Births dashboard -> navigate to last Pivot chart -> Sort all filed Ascendingly

@mistercrunch mistercrunch added the !deprecated-label:bug Deprecated label - Use #bug instead label Dec 28, 2017
@zancos
Copy link

zancos commented Jun 13, 2018

Same here. When sorting, 1.02k is smaller that 2.00 if using .3s number format.
We are using version | "0.25.6"

pivot_sorting_error

@tristix
Copy link

tristix commented Oct 11, 2018

This is still an issue.

When sorting, 900 is > 1.2k apparently.

We migrated from v0.20 -> v0.26 this morning and it was noticeable straight away

@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 10, 2019
@rumbin
Copy link
Contributor

rumbin commented Apr 10, 2019

Please do not close this bug unless ist has been fixed

@stale stale bot removed the inactive Inactive for >= 30 days label Apr 10, 2019
@kristw kristw added the .vis label Apr 18, 2019
@stale
Copy link

stale bot commented Jun 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Jun 17, 2019
@mistercrunch
Copy link
Member

It's been fixed:
Screen Shot 2019-06-17 at 10 41 25 PM

@tristix
Copy link

tristix commented Jun 18, 2019

Amazing thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

6 participants