Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(alert/report): add 'not null' condition option to modal #12077

Merged
merged 4 commits into from
Dec 17, 2020
Merged

feat(alert/report): add 'not null' condition option to modal #12077

merged 4 commits into from
Dec 17, 2020

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Dec 16, 2020

SUMMARY

  • Add 'Not Null' option to ALERT IF... input
  • When selected, disable VALUE input
  • Fix validator_config field to send operator when selected and not null only when corresponding option is selected
  • Update useSingleViewResource hook to add error handling on updateResource/createResource methods
  • Update error handling on edit/create so modal does not close

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2020-12-15 at 4 04 30 PM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 16, 2020 •
edited
Loading

Codecov Report

Merging #12077 (83206ed) into master (5e811a1) will decrease coverage by 3.28%.
The diff coverage is 7.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12077      +/-   ##
==========================================
- Coverage   66.95%   63.66%   -3.29%     
==========================================
  Files         957      959       +2     
  Lines       47003    47170     +167     
  Branches     4589     4622      +33     
==========================================
- Hits        31471    30032    -1439     
- Misses      15404    16954    +1550     
- Partials      128      184      +56
Flag Coverage Δ
cypress ?
javascript 62.60% <7.40%> (-0.08%) ⬇️
python 64.30% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/CRUD/alert/types.ts 100.00% <ø> (ø)
superset-frontend/src/views/CRUD/hooks.ts 51.87% <0.00%> (-6.29%) ⬇️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 49.10% <9.52%> (-1.30%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/chart/ChartContainer.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/reducers/index.js 0.00% <0.00%> (-100.00%) ⬇️
...et-frontend/src/dashboard/containers/Dashboard.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e811a1...83206ed. Read the comment docs.

@riahk riahk requested a review from willbarrett December 16, 2020 22:26
@willbarrett willbarrett requested a review from nytai December 16, 2020 22:41
@nytai nytai changed the title feat: alert/report modal: add 'not null' condition option feat(alert/report): add 'not null' condition option to modal Dec 16, 2020
nytai
nytai approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nytai nytai merged commit 08b3ebe into apache:master Dec 17, 2020
@nytai nytai deleted the moriah/alert-report-condition-update branch December 17, 2020 01:13
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Dec 18, 2020
Merge remote-tracking branch 'upstream/master' into multi-queries
a61c985 
* upstream/master: (55 commits)
  feat(explore): time picker enhancement (apache#11418)
  feat: update alert/report icons and column order (apache#12081)
  feat(explore): metrics and filters controls redesign (apache#12095)
  feat(alerts/reports): add refresh action (apache#12071)
  chore: add latest tag action (apache#11148)
  fix(reports): increase crontab size and alert fixes (apache#12056)
  Small typo fix in Athena connection docs (apache#12099)
  feat(queries): security perm simplification (apache#12072)
  feat(databases): security perm simplification (apache#12036)
  feat(dashboards): security permissions simplification (apache#12012)
  feat(logs): security permissions simplification (apache#12061)
  chore: Remove unused CodeModal (apache#11972)
  Fix typescript error (apache#12074)
  fix: handle context-dependent feature flags in CLI (apache#12088)
  fix: Fix "View in SQLLab" bug (apache#12086)
  feat(alert/report): add 'not null' condition option to modal (apache#12077)
  bumping superset ui to 15.18 and deckgl to 0.3.2 (apache#12078)
  fix: Python dependencies in apache#11499 (apache#12079)
  reset active tab on open (apache#12048)
  fix: improve import flow UI/UX (apache#12070)
  ...
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

@willbarrett willbarrett willbarrett approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@riahk @codecov-io @willbarrett @nytai @mistercrunch