-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): enabling and deprecating a few feature flags #24232
Conversation
…default (board tasks 44, 46)
… VERSIONED_EXPORT
Codecov Report
@@ Coverage Diff @@
## master #24232 +/- ##
==========================================
- Coverage 68.30% 68.25% -0.06%
==========================================
Files 1957 1957
Lines 75594 75596 +2
Branches 8224 8222 -2
==========================================
- Hits 51637 51600 -37
- Misses 21849 21888 +39
Partials 2108 2108
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Tagging this as
feat
because it enables flags by default. Could be achore
¯\_(ツ)_/¯As per the 3.0 task board:
ENABLE_TEMPLATE_REMOVE_FILTERS
(item 37)DRILL_TO_DETAIL
(item 44)DASHBOARD_CROSS_FILTERS
(item 46)VERSIONED_EXPORT
(item 36)ENABLE_TEMPLATE_REMOVE_FILTERS
(item 37)BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION