chore: Sets DASHBOARD_VIRTUALIZATION feature flag to True by default #26636
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
risk:breaking-change
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26636 +/- ##
==========================================
+ Coverage 69.06% 69.07% +0.01%
==========================================
Files 1930 1937 +7
Lines 75309 75471 +162
Branches 8429 8460 +31
==========================================
+ Hits 52013 52135 +122
- Misses 21149 21179 +30
- Partials 2147 2157 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
approved these changes
Jan 16, 2024
|
@michael-s-molina I’m surprised there’s no tests which needed updating from a mocking perspective based on this change. |
Muhammed-baban
pushed a commit
to intellica-tech/reporting-tool
that referenced
this pull request
Jan 19, 2024
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As part of the 4.0 approved initiatives, this PR sets the
DASHBOARD_VIRTUALIZATIONfeature flag toTrueby default. This feature was introduced by #21438 and will enable virtualization when rendering a dashboard's charts in an attempt to reduce the number of elements (DOM nodes) rendered at once. This is especially useful for large dashboards.TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION