[fix] tox running of specific tests

[john-bodley]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

This PR corrects running of specific tests in tox, i.e.,

tox -e py36-mysql tests/sqllab_tests.py 

whereas previously this would have run as,

tox -e py36-mysql tests tests/sqllab_tests.py 

meaning the entire test suite was run prior to the test(s) for interest. tox provides a mechanism for default positional arguments (per here) and thus these are equivalent (the first being the default) for running the entire suite:

tox -e py36-mysql
tox -e py36-mysql tests

Note when running individual tests I ran into the RuntimeError: Working outside of application context. error during the import phase. The fix is to add the import tests.test_app import (which creates the app context) where necessary. I believe the entire test suite worked only because the first file alphabetically included the import.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

to: craig-rueda @etr2460 @mistercrunch @villebro

[codecov-io]

Codecov Report

Merging #9097 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #9097      +/-   ##
=========================================
- Coverage   59.15%   59.1%   -0.06%     
=========================================
  Files         370     372       +2     
  Lines       11818   11920     +102     
  Branches     2900    2918      +18     
=========================================
+ Hits         6991    7045      +54     
- Misses       4648    4693      +45     
- Partials      179     182       +3

Impacted Files	Coverage Δ
...set/assets/src/dashboard/actions/dashboardState.js	31.72% <0%> (-9.24%)	⬇️
superset/assets/src/chart/chartAction.js	43.24% <0%> (-4.71%)	⬇️
...ssets/src/dashboard/components/PropertiesModal.jsx	6.55% <0%> (-0.72%)	⬇️
...uperset/assets/src/dashboard/components/Header.jsx	41.79% <0%> (-0.28%)	⬇️
...t/assets/src/views/dashboardList/DashboardList.tsx	73.14% <0%> (-0.25%)	⬇️
...t/assets/src/dashboard/reducers/getInitialState.js	0% <0%> (ø)	⬆️
...ssets/src/dashboard/containers/DashboardHeader.jsx	100% <0%> (ø)	⬆️
superset/assets/src/welcome/App.jsx	0% <0%> (ø)	⬆️
superset/assets/src/logger/LogUtils.js	100% <0%> (ø)	⬆️
...set/assets/src/dashboard/util/setPeriodicRunner.js	66.66% <0%> (ø)
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916d184...8a399db. Read the comment docs.

[villebro]

Thanks for fixing this @john-bodley , I was wondering why I wasn't able to run only a subset of tests a few weeks ago but didn't look into it. I'm sure this was working before; any idea if this is a regression from a code change or perhaps a consequence of bumping tox or similar?

[nytai]

👏 this was driving me crazy last week

[john-bodley]

@villebro I believe the regression was introduced in #8418 though without the tests directory the tests don't seem to run correctly (even those nosetests is supposed to sniff out all tests) so I'm a little perplexed as to how it worked previously.

I've augmented the commit to include missing imports as running certain individual files would fail with the familiar app context error. It seems that the test suite worked merely because the first test alphabetically imported the correct file.

[john-bodley]

-e and --exclude= are equivalent, though I though --exclude was more descriptive.