Gregt/negative viewable threshold #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engywook2005
changed the title
src/utils/isInViewport.js
Outdated
| const inViewport = | ||
| rect.bottom >= viewport.top + height * offset && | ||
| rect.right >= viewport.left + width * offset && | ||
| rect.top <= viewport.bottom - height * offset && | ||
| rect.left <= viewport.right - width * offset; | ||
|
|
||
| console.log(`${el.parentElement.getAttribute('class')}. VT is ${offset}. top is ${rect.top}, vs ${viewport.bottom - height * offset}. bottom is ${rect.bottom}, vs ${viewport.top + height * offset}. in viewport? ${inViewport}`); |
There was a problem hiding this comment.
Lets remember to remove this prior to launch
There was a problem hiding this comment.
Log call removed... @andrewb over to you to have a look. Let me know what you think.
Engywook2005
changed the title
andrew-sotiriou
pushed a commit
that referenced
this pull request
Dec 18, 2023
* Can work with negative viewability threshold. * Offset in log remark is now VT for clarity. * Checking for isNaN * removed logging Co-authored-by: Engywook2005 <[email protected]>
andrew-sotiriou
added a commit
that referenced
this pull request
Jan 8, 2024
* Enable non-personalized Ads (#1) * Enable non-personalized Ads According to EU regulations, it is mandatory to enable users to opt-out to tracking cookies GPT allows us to respect this law using the `npa` flag on Ads. * Adding npa flag to re-render props * Fix npa variable in componentWillReceiveProps * Increase the bundle-size to accept the new amount of code * Changed the place where NPA is set * Update Bling.js Fixes an issue where `setAttributes` can be called when there is no ad slot * Bump to 2.0.2 * chore: Update package.json Update package.json name and urls after forking * chore: Update API list Update GPT API list to latest * chore: Add prettier config (#3) Add prettier config and fix bracket spacing mismatch * Fixing things * fix: Don't setState on unmounted ad (#5) Don't set state on an unmounted ad. Cribbed from axioscode@9425436. * fix: Fix undefined function if apiNotReady (#6) Fix undefined function if apiNotReady. Cribbed from ticketmaster@5ef19b1. * fix: Replace hasOwnProperty with more reliable check (#7) Replace hasOwnProperty with more reliable check. Cribbed from nfl@8826ee3. * fix: Do not refresh all ads when new component loads (#8) Fixes an issue where all ad slots would reload when syncCorrelator was true and a new slot was added * refactor: Check for updateCorrelator (#9) Check for deprecated updateCorrelator method before calling * build: Update radium (#10) * build: Update radium Update radium to fix "TypeError: Cannot read property 'object' of undefined" when running examples * Use ^ * Fixing things * fix: Stop multiple refresh on mq change (#11) * fix: Stop multiple refresh on mq change Stops multiple calls to instance.refresh() on media query change. This can happen when an instance is associated with multiple instances. * Only debounce this.refresh * Fix comment * Merge it * feat: Add support for custom refresh function (#14) Adds the ability to specify a custom refresh function using `configure`. This function replaces the call to `pubads().refresh`. This is useful for certain header bidding configurations, such as App Nexus that requires to `pbjs.refresh` to be called. * work this time * perf: Use googletag.cmd.push instead of timeout to process queue (#16) Use googletag.cmd.push instead of timeout to check if pubads is ready. Fixes issue with recurring handler. * work this time * Update all instances of googletagservices gpt url to securepubads gpt url (#20) * Update all instances of googletagservices gpt url to securepubads gpt url * Add UNSAFE so we can look to update REACT * update remaining paths; use https to avoid redirect Co-authored-by: Andrew Berry <[email protected]> * update linking instructions; some cleanup (#21) * remove enableServices timeout from GPT mock (#22) * Release 2.1.2 (#24) * Remove deprecated ContentService (#23) * Remove deprecated ContentService usage * Update test * doc updates Co-authored-by: Andrew Sotiriou <[email protected]> * update changelog and version in package.json (#25) * Ton of MI updates (#26) * Ton of MI updates * Minor changes * change release and update changelog (#27) * Gregt/negative viewable threshold (#28) * Can work with negative viewability threshold. * Offset in log remark is now VT for clarity. * Checking for isNaN * removed logging Co-authored-by: Engywook2005 <[email protected]> * Changed version and updated changelog (#29) * Changed version and updated changelog * Fixed typo in package.json Co-authored-by: Engywook2005 <[email protected]> * Andrew s/neg vt issue (#30) * Fixes for neg VT * Update isHidden * Cleanup * Remove log * Update call * Release 2 1 6 (#31) * update packageJSON version * Update changelog * add prepare script * Revert "add prepare script" This reverts commit 49fcf5b. * React v17 support (#32) * update deps * update radium to version supporting react 17 * add prepare script * remove prepare script * findDOMNode is deprecated * make peerDependencies more lenient * ref needs to be on different node * Reverting the version as i will do that in another step --------- Co-authored-by: Andrew Sotiriou <[email protected]> * release branch (#33) * Remove console log (#34) * Update package and remove console log (#35) * Gregt/lazy load (#36) * Add stuff for lazy load * First shot at ignoring isInViewport response. * Will render ads even if the inviewport check fails * Removed commented out line of code * Version bump and changelog update --------- Co-authored-by: Andrew Sotiriou <[email protected]> Co-authored-by: Greg Thorson <[email protected]> --------- Co-authored-by: Carlos A. Gomes <[email protected]> Co-authored-by: Carlos Gomes <[email protected]> Co-authored-by: Michael Blanchard <[email protected]> Co-authored-by: Mike Kruk <[email protected]> Co-authored-by: Andrew Berry <[email protected]> Co-authored-by: Andrew Berry <[email protected]> Co-authored-by: Greg Thorson <[email protected]> Co-authored-by: Engywook2005 <[email protected]> Co-authored-by: Stephen Sauceda <[email protected]> Co-authored-by: Greg Thorson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables support of negative viewability