Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert and remove NEG VT updates #40

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

andrew-sotiriou
Copy link

@andrew-sotiriou andrew-sotiriou commented Apr 16, 2024

What does this PR do?

Removes NEG VT checks

How can this change be manually tested?

See OXY PR

Asana Card

https://app.asana.com/0/1198498632694766/1200448295134366/f

Questions or concerns about this change?

n/a

Deployment Notes

tied to an OXY PR: https://github.com/apartmenttherapy/oxygen/pull/6038


PR Readiness

  • Changes have been validated in local dev

Code Readiness

Automated Testing

  • Unit tests are written at the appropriate level given the code’s risk-level
  • Existing tests still pass
  • No unnecessary test runner output, e.g. debugging or warnings are not present in Jest or Unittest output

Other Considerations

  • Relevant documentation updated in Slite

Also consider this PR's impact on architecture and security; AMP, Apple News, RSS; SEO, GA, performance and accessibility.

Please see Post Merge for additional responsibilities after this PR is merged.

@andrew-sotiriou andrew-sotiriou requested a review from andrewb April 22, 2024 19:25
@andrew-sotiriou andrew-sotiriou merged commit e59cd82 into master Apr 23, 2024
@andrew-sotiriou andrew-sotiriou deleted the andrew-s/remove-neg-vt branch April 23, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants