Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a cache with "--timeoutInSec 300" results in incorrect "expirySettings" #181

Open
kurtkanaskie opened this issue Dec 2, 2019 · 3 comments

Comments

@kurtkanaskie
Copy link
Contributor

For example:
createCache -N --cache test-cache -o ORG -e ENV --cacheExpiryInSecs 300

results in:
"expirySettings": { "expiryDate": { "value": "12-31-9999" }, "timeoutInSec": { "value": "300" } }

@hiteshshahjee
Copy link
Contributor

@kurtkanaskie commented about this on PR-179

With PR-176, we added support to pass expirySettings while making createcache call. After multiple discussion we agreed that we will always pass default value/user provided for expiryDate. timeoutInSec is passed when provided by user.
Even though getcache return both expiryDate & timeoutInSec, in edge portal it only show timeoutInSec in the UI.

@chayaSubhash
Copy link

Any ETA on this fix release?

@whitlockjc
Copy link
Member

I think we were waiting on @hiteshshahjee to respond to #179 but I've bumped that PR to get what we needed. Once merged, release will happen immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants