Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the isomorphic-fetch dependency #1718

Closed
gajus opened this issue May 22, 2017 · 4 comments
Closed

Remove the isomorphic-fetch dependency #1718

gajus opened this issue May 22, 2017 · 4 comments

Comments

@gajus
Copy link

gajus commented May 22, 2017

It is not the responsibility of a library to polyfill browser features.

isomorphic-fetch is now being pulled into a bundle for no good reason.

Remove the isomorphic-fetch dependency and document that user needs to polyfill Fetch if the target environment does not support Fetch API (or recommend to use https://polyfill.io/v2/docs/).

@cesarsolorzano
Copy link
Contributor

@gajus Isn't this the same issue you described in #645?

@gajus
Copy link
Author

gajus commented May 22, 2017

oh, lol. I forgot about it by now.

Yes it is.

@gajus gajus closed this as completed May 22, 2017
@pckhoi
Copy link

pckhoi commented Jul 21, 2017

isomorphic-fetch is still being required for no good reason.

I see that recent releases of apollo-client no longer require isomorphic-fetch, yet it require apollo-link which require apollo-fetch which require isomorphic-fetch. Ultimately apollo-client still depend on isomorphic-fetch.

@gajus
Copy link
Author

gajus commented Jul 21, 2017

Patience.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants