Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API cleanup: use "scalar" instead of "custom scalar" #3815

Closed
BoD opened this issue Jan 25, 2022 · 0 comments
Closed

API cleanup: use "scalar" instead of "custom scalar" #3815

BoD opened this issue Jan 25, 2022 · 0 comments
Labels
🧊 Icebox Features that would be nice but probably won't happen in the near future ⚠️ Breaking Change To be done in next major version

Comments

@BoD
Copy link
Contributor

BoD commented Jan 25, 2022

It is now possible to specify a type and adapter for built-in scalars (#3748) so the terminology "custom scalar" could be simply "scalar". The class CustomScalarAdapters (and related functions customScalarAdapters addCustomScalarAdapter on ApolloClient.Builder) can be renamed.

Since this is a breaking change, keeping it for the next major release.

See also #3813 where we discuss replacing it by or embedding it in an AdapterContext.

There are also a few other symbols:

  • com.apollographql.apollo3.api.CustomScalarType
  • com.apollographql.apollo3.compiler.codegen.kotlin.file.CustomScalarBuilder
  • com.apollographql.apollo3.compiler.ir.IrCustomScalar
@martinbonnin martinbonnin added the ⚠️ Breaking Change To be done in next major version label Mar 30, 2022
@martinbonnin martinbonnin mentioned this issue Sep 15, 2022
Closed
33 tasks
This was referenced Apr 18, 2023
Closed
Closed
@BoD BoD mentioned this issue Apr 26, 2023
Merged
@BoD BoD added the 🧊 Icebox Features that would be nice but probably won't happen in the near future label Jun 14, 2024
@bignimbus bignimbus mentioned this issue Jul 25, 2024
Open
19 tasks
@BoD BoD closed this as completed Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🧊 Icebox Features that would be nice but probably won't happen in the near future ⚠️ Breaking Change To be done in next major version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BoD @martinbonnin