Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation: field selection merging #306

Closed
lrlna opened this issue Sep 21, 2022 · 2 comments · Fixed by #470
Closed

validation: field selection merging #306

lrlna opened this issue Sep 21, 2022 · 2 comments · Fixed by #470
Assignees
@goto-bus-stop
Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation

Comments

@lrlna
Copy link
Member

lrlna commented Sep 21, 2022 •
edited by goto-bus-stop
Loading

implement field selection merging, spec.

in the compiler's db, fields should likely still be separated, but have an api that provides access to the merged field selection which is to be used in validation.
@lrlna lrlna added the apollo-compiler issues/PRs pertaining to semantic analysis & validation label Sep 21, 2022
@lrlna lrlna mentioned this issue Feb 15, 2023
Merged
@yanns
Copy link
Contributor

yanns commented Mar 1, 2023

The validation should check if the fields can be merged or not?
Or should we also merge the fields? For which validation?

@yanns
Copy link
Contributor

yanns commented Mar 2, 2023

Maybe it's worth taking inspiration from sangria-graphql-org/sangria#12

@yanns yanns mentioned this issue Mar 3, 2023
Closed
@goto-bus-stop goto-bus-stop mentioned this issue Mar 9, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@goto-bus-stop goto-bus-stop

Labels
apollo-compiler issues/PRs pertaining to semantic analysis & validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(compiler): validate conflicting fields in selection sets apollographql/apollo-rs
3 participants
@yanns @goto-bus-stop @lrlna