Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing naming of function passed to Array.map #138

Open
LeonardoGentile opened this issue May 6, 2020 · 0 comments
Open

Confusing naming of function passed to Array.map #138

LeonardoGentile opened this issue May 6, 2020 · 0 comments

Comments

@LeonardoGentile
Copy link

Hello,
not a real issue but just a naming of a method that confused me for a bit.
In datasource/launch there is method called launchReducer passed to Array.map. This method is responsible to take each launch returned by the Rest API and mapping it to another object.
So I guess this function should be called lauchMapper, because that's what it does. It doesn't reduce multiple element into a single one, isn't it?

Just highlighting this because it is a bit confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant