Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Upgrade React and Jest Presets #352

Closed
johnthepink opened this issue Dec 3, 2016 · 3 comments
Closed

Upgrade React and Jest Presets #352

johnthepink opened this issue Dec 3, 2016 · 3 comments

Comments

@johnthepink
Copy link
Contributor

We are currently locked at react 15.4.0-rc2. Upgrading to 15.4.1 introduced an issue on the CI with importing "React" vs "react". See this comment.

Using the jest preset included in react-native since 0.38 actually fixed this issue, and cleaned up a lot of logging, but caused tests to fail that were making actual network requests, see this travis build

We should figure out the network issue and update react all the way.

@jbaxleyiii
Copy link
Contributor

@johnthepink this should actually pretty really easy now that we are using jest. I'll try to mock those responses this weekend 👍

@johnthepink
Copy link
Contributor Author

@jbaxleyiii oh sweet! I thought about doing that, but wasn't sure if we wanted the actual network requests.

@johnthepink
Copy link
Contributor Author

I like mocking them better

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants