examples: added java7, which uses the host's apt-get - WIP #158
Conversation
| trap rmDirectories EXIT | ||
|
|
||
| pushd ${PACKAGESDIR} | ||
| apt-get download \ |
There was a problem hiding this comment.
holy giant unordered list of packages batman.
There was a problem hiding this comment.
Well it came from the giant unordered list of packages that was a separate file before. Think if I kept this in a separate file still it would be a little saner?
There was a problem hiding this comment.
no strong opinion, do what you think is best
There was a problem hiding this comment.
IMO this should go into separate .txt file which then could be used like $(cat deb-requirements.txt) - any further modification of this list would not touch this file.
|
Sure, if it works lgtm |
|
ping |
|
Needs testing. Will test next week. |
| shopt -s nullglob | ||
| for d in ${PACKAGESDIR}/*.deb; do | ||
| echo "Extracting $d" | ||
| dpkg-deb -x ${d} ${TMPDIR} |
There was a problem hiding this comment.
Doing that - You are skipping postinst process, also skipping of post install triggers (ldconfig for example).
Maybe using debootstrap with --include parameter would be more secure option for doing above work?
There was a problem hiding this comment.
I tried using debootstrap to make a base, and without installing anything on top of that the ACI is at 134 MB.
I tried using the instructions in this SO post to just apt-get install nginx into a different root dir. It pulled in so many packages (packages like apt, adduser, mount, e2fslibs, ...) that it would use up 163 MB of disk space, and ended up erroring on the install process when /usr/bin/apt-listchanges wasn't found.
Just extracting deb files into a directory skips potentially important install steps, and doing it correctly signs you up for containers greater in size than 134 MB. I really think the only decent solution to integrating a package manager with a container build system is nix2aci, where you have a package manager that doesn't need to include everything and the kitchen sink in case there are undeclared dependencies (nix is guaranteed to actually know the dependencies of its packages, instead of "oh the guy had this binary available when he built the package so you need to too").
So @jonboulle, want me to leave this in its current state, make the containers massive, or drop this and just point to nix2aci?
There was a problem hiding this comment.
Can you replace this with a nix java7 example?
|
Closing in favor of #158 (comment). |
Putting this up for review. Rewrote the java7 section of https://github.com/appc/build-repository to use acbuild.
Addresses some (maybe all?) of appc/build-repository#10.
cc @jonboulle