Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a capability to customize the default state change timeout on app startup #877

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

mykola-mokhnach
Copy link

@mykola-mokhnach mykola-mokhnach commented Mar 27, 2024

Sometimes I can observe apps that take really long to start or cannot start at all because of the fact they block the main thread, so it is not idling, thus preventing XCTest from interacting with it. The default XCTest timeout for app state change is 60 seconds, although we should be able to reduce it and fail the session startup earlier if we have such app.

@mykola-mokhnach mykola-mokhnach changed the title feat: Add a capability to change the default state change timeout on app startup feat: Add a capability to customize the default state change timeout on app startup Mar 27, 2024
@KazuCocoa
Copy link
Member

let me test tonight

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg. I confirmed the error case as well with 0.1 sec with apple's map app

@mykola-mokhnach mykola-mokhnach merged commit 98351c3 into master Mar 28, 2024
46 checks passed
@mykola-mokhnach mykola-mokhnach deleted the app_launch_state branch March 28, 2024 08:05
github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
## [8.2.0](v8.1.0...v8.2.0) (2024-03-28)

### Features

* Add a capability to customize the default  state change timeout on app startup ([#877](#877)) ([98351c3](98351c3))
Copy link

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mykola-mokhnach
Copy link
Author

lg. I confirmed the error case as well with 0.1 sec with apple's map app

Thanks for checking it @KazuCocoa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants