New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small cleanup to fsx.c #2

Open

macosforgebot opened this issue Jan 9, 2015 · 1 comment

Labels

macosforgebot commented Jan 9, 2015

kirk@… originally submitted this as ticket:14

Owner: somebody
Cc: krussell@…

kirussel/portablefstools@master...kirussel/misc

I have proposed some changes that fixes the following:

for msync(), uses MS_SYNC, instead of hard coding zero
for mmap(), uses MAP_FAILED, instead of harding coding -1
for getopt(), using -1, instead of EOF
added "y" to the getopt string -- this is already implemented but is missing from the command line args

The text was updated successfully, but these errors were encountered:

Author

macosforgebot commented Jan 9, 2015

kirk@… originally submitted this as attachment:misc_patch.txt:⁠ticket:14

Attachment misc_patch.txt (1.4 KB) added

patch

macosforgebot added blocker defect labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment