fix: File name too long when prompt too long (#52) #53
Conversation
|
I also patched up the error on the Swift side. Would you mind merging my commit into this PR? |
|
@philipturner done, now we patched both swift and python 🍻 |
|
Thank you for your interest in contributing to Core ML Stable Diffusion! Please review CONTRIBUTING.md. If you would like to proceed with this pull request, please indicate your agreement to the terms outlined in CONTRIBUTING.md by checking the box below. We appreciate your interest in the project!
|
|
#19 has been merged, so looks like I need to rollback your changes first @philipturner :) |
soulteary
force-pushed
the
fix/file-name-too-long
branch
from
e19dc42
to
9057bee
Compare
|
|
There’s still the issue of when your folder structure is 200 characters long and the file is 75 characters. Then the complete path exceeds 255 characters and causes a runtime crash. Also have you looked at how Auto 1111’s WebUI permits prompts that are integer multiples of 75? I think limiting the file name to 75 characters is fixing a symptom, not the problem. Furthermore, the maximum prompt size is 75 tokens, not 75 characters. @atiorh I request that you review and/or revert any commits conflating 75 characters with 75 comma-separated phrases. |
|
What about taking the hash of the prompt? |
issue: #52