Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Module aliasing in SwiftPM #4023

Merged
merged 19 commits into from
Feb 9, 2022
Merged

Support Module aliasing in SwiftPM #4023

merged 19 commits into from
Feb 9, 2022

Conversation

elsh
Copy link
Contributor

@elsh elsh commented Jan 14, 2022

Resolves rdar://87583788

@elsh
Support Module aliasing in SwiftPM
ffed84c 
Resolves rdar://87583788
@elsh
Copy link
Contributor Author

elsh commented Jan 14, 2022

@swift-ci test

@tomerd
Copy link
Contributor

tomerd commented Jan 15, 2022

@swift-ci please smoke test

@elsh
Copy link
Contributor Author

elsh commented Jan 15, 2022

swiftlang/swift-llbuild#758
@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Jan 17, 2022

swiftlang/swift-llbuild#758
@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Jan 18, 2022

swiftlang/swift-llbuild#758
@swift-ci Please Build Toolchain macOS Platform

@tomerd
Copy link
Contributor

tomerd commented Jan 18, 2022

@elsh in order to build a toolchain, you need to create a PR on the swift repositories and then mention all the related PR (like this one and the llbuild one) for cross repo building. iow, the SwiftPM repo is not setup to create toolchains, you have to create an empty PR on the swift toolchain to do that.

@elsh elsh mentioned this pull request Jan 18, 2022
Closed
tomerd
tomerd reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice. couple of small comments

@tomerd
Copy link
Contributor

tomerd commented Feb 4, 2022

probably worth adding at least one fixtures in the functional tests area for a end-to-end test of the functionality

@elsh
Copy link
Contributor Author

elsh commented Feb 4, 2022

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Feb 4, 2022

probably worth adding at least one fixtures in the functional tests area for a end-to-end test of the functionality

Planning to add that in a separate PR; lmk if you think it should accompany this PR.

@elsh
Copy link
Contributor Author

elsh commented Feb 5, 2022

@swift-ci smoke test

@tomerd
Copy link
Contributor

tomerd commented Feb 5, 2022

i think at least one end-to-end (fixture) test is in place

@elsh
Copy link
Contributor Author

elsh commented Feb 8, 2022

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Feb 8, 2022

@swift-ci smoke test

tomerd
tomerd approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good once fixture path are fixed

@elsh
Copy link
Contributor Author

elsh commented Feb 8, 2022

@swift-ci smoke test

@elsh
Copy link
Contributor Author

elsh commented Feb 9, 2022

@swift-ci smoke test

@elsh elsh merged commit 956eba8 into main Feb 9, 2022
@tomerd
Copy link
Contributor

tomerd commented Feb 9, 2022

🥳

@elsh elsh deleted the es-mod branch February 18, 2022 23:26
@alessionossa alessionossa mentioned this pull request Nov 13, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abertelrud abertelrud abertelrud left review comments

@tomerd tomerd tomerd approved these changes

@neonichu neonichu neonichu approved these changes

Assignees

@elsh elsh

Labels
add to change log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elsh @tomerd @neonichu @abertelrud