[NFC] Add 'package' access modifier to AccessLevel #62652
Conversation
|
@swift-ci test |
elsh
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
elsh
changed the title
|
This PR contains changes in #62704, which will be rebased after it merges. |
|
@swift-ci test |
elsh
force-pushed
the
es-pkg-acl
branch
2 times, most recently
from
f324a65 to
169cb0f
Compare
|
@swift-ci test |
elsh
changed the title
|
Could you also add a test case in the new parser to make sure we parse it correctly there as well? |
@elsh already did swift-syntax: swiftlang/swift-syntax#1156 and swiftlang/swift-syntax#1163 |
|
Oh, nice. I didn’t remember those PRs. |
Resolves rdar://103534243
Resolves rdar://104198440
|
@swift-ci test |
|
@swift-ci test |
| @@ -1742,6 +1742,7 @@ SDKContext::shouldIgnore(Decl *D, const Decl* Parent) const { | |||
| case AccessLevel::Private: | |||
| case AccessLevel::FilePrivate: | |||
| return true; | |||
| case AccessLevel::Package: | |||
| case AccessLevel::Public: | |||
| case AccessLevel::Open: | |||
| break; | |||
There was a problem hiding this comment.
We may want to revisit this later. I believe this logic is used by the ABI checker to report changes that would break clients that were built against an old ABI and couldn't use the new ABI at runtime. Package clients should always be version locked, the ABI checker can likely ignore package ABI breaks.
There was a problem hiding this comment.
As is it's more restrictive, so making it more permissive later shouldn't be a problem.
There was a problem hiding this comment.
Good to know. Will add a note to keep track.
| @@ -1516,6 +1517,7 @@ SubclassScope SILDeclRef::getSubclassScope() const { | |||
| // SILModule, so we don't need to do anything. | |||
| return SubclassScope::NotApplicable; | |||
| case AccessLevel::Internal: | |||
| case AccessLevel::Package: | |||
| case AccessLevel::Public: | |||
| // If the class is internal or public, it can only be subclassed from | |||
| // the same AST Module, but possibly a different SILModule. | |||
There was a problem hiding this comment.
This whole function is interesting for what we discussed about packageopen.
|
🎉 |
This PR adds a new access modifier
packagebut doesn't do anything with it yet.Ref: swiftlang/swift-evolution#1877
The
packageaccess level will be similar topublicin that it's accessible from other modules and subclassable only within the defining module as long as the modules are in the same package.The upcoming PRs will address properly type-checking with the
packageaccess modifier.Resolves rdar://103462581, rdar://104198440